Port to GTK4 #157
Open
Port to GTK4 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add CanberraGtk4 Namespace for Replacement of libcanberra-gtk The only function that we was using from libcanberra-gtk was context_get(), CanberraGtk4.context_get() reimplements it using the Gtk4 types. * Update README and CI * lint * Make the code actually work
|
@zenitsudev did you want to update this draft? :) |
|
sorry for the late reply. I am now free so I can work on this |
|
On my testing, it works flawlessly now. However, there are signals where I commented some codes because I am not sure about what to do with them. The thing that maybe left to do as for now is to be able to position the notifications in their proper place. |
|
Goes with elementary/gala#1427 A window title is set as a unique identifier for the notification bubbles. It is hidden though, so it will not be visible and serve only as a name the window manager can anticipate so it can place the notification bubble in the proper area. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial port to GTK4.
Problem:
Blocked by: