Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Confirmations #206

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Jul 5, 2023

Fixes #76

It's a bit broken for now.

@lenemter
Copy link
Member Author

lenemter commented Jul 5, 2023

We need to change the confirmation types of gala, sound indicator and power indicator.

  1. Gala should give different confirmation types for sound and brightness.
  2. Gala sound type and sound indicator types should match. This should be done in case user changes sound using media keys and then changes sound by scrolling on the Wingpanel icon.
  3. Same thing for power indicator.

src/Confirmation.vala Outdated Show resolved Hide resolved
@lenemter
Copy link
Member Author

lenemter commented Jul 7, 2023

@Marukesu I tried to use setter. Can you check please if that's what you had in mind?

@lenemter lenemter requested a review from Marukesu July 8, 2023 06:10
@Marukesu
Copy link
Contributor

Marukesu commented Jul 8, 2023

  1. Gala should give different confirmation types for sound and brightness.
  2. Gala sound type and sound indicator types should match. This should be done in case user changes sound using media keys and then changes sound by scrolling on the Wingpanel icon.
  3. Same thing for power indicator.

this is broken because ShowOSD doesn't have anything that can be thought as "type", and even if we add something that can be saw this way in Gala, GSD won't use it anyway.

i think the path forward here is moving out from GSD's MediaKeys plugin. and having the indicators deal with the keyboard shortcuts. that would have the plus that we won't end with a notification when the indicator popover is open, like happens now.

Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

src/Confirmation.vala Outdated Show resolved Hide resolved
src/Confirmation.vala Show resolved Hide resolved
src/Confirmation.vala Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Confirmations
2 participants