Handle Notification Hints in the Server #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already need to check thoses to block the GSD notfications instead of re-checking they in the notification class, only get they value one time in notify(). Signed-off-by: Gustavo Marques <[email protected]>
the server is now in the responsability in defining the title and body, if it end up without one of those, we error out. body sanitization was moved from the bubble to the notification and extented to deal with carriage returns and force feed characters. Signed-off-by: Gustavo Marques <[email protected]>
the notification have now explicit image and badge properties the server set them to the right icons, and masking happens in the bubble. MaskedImage was updated to handle any GLib.LoadableIcon. Signed-off-by: Gustavo Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a push to cleanup the Notification class to make it also usable with other server interfaces, hints are a exclusive concept of the Freedesktop's Notifications interface, and as such, it make more sense to deal with them in the server.
this introduce two behaviour changes:
app_iconis a file path or uri, it will be masked when used as primary image of the bubble, but not when used as a badge, this happens because there's no way to differ a GLib.FileIcon icon and a GLib.FileIcon image, given that the focus is the Gtk/Portal interface, i choose to not complicate the logic in the bubble to deal with this conner case.app_name,summaryor thedesktop-entryhint is specified, we throw a error rather than showing a notification without title.