Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FdoServer: drop bubble reference when destroy() is emitted #213

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

Marukesu
Copy link
Contributor

our bubble map was keeping a reference to the bubble, stoping it from being destroyed. drop our reference when destroy() is emitted.

Fixes: #212.

@leolost2605
Copy link
Member

leolost2605 commented Jul 28, 2023

Thanks for the quick response :)
I think with the updates to #211 we won't need this anymore but if you want to keep it as a failsave for future errors I'm happy to approve

@Marukesu
Copy link
Contributor Author

i perfer to revert #211 back to the approved state, the changes done there will make close_notification() throw for notifications in the tray.

@leolost2605
Copy link
Member

Oh man I'm starting to loose track 😅. I reverted the changes there

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this line could probably also use a null check

@Marukesu
Copy link
Contributor Author

Good catch! Added the null check.

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@danirabbit danirabbit enabled auto-merge (squash) August 18, 2023 17:00
@danirabbit danirabbit merged commit e8d0592 into master Aug 18, 2023
4 checks passed
@danirabbit danirabbit deleted the maru/drop-bubble branch August 18, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible notification blocking input
3 participants