-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FdoServer: drop bubble reference when destroy()
is emitted
#213
Conversation
Thanks for the quick response :) |
i perfer to revert #211 back to the approved state, the changes done there will make |
Oh man I'm starting to loose track 😅. I reverted the changes there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but this line could probably also use a null
check
8702ac2
to
1a9f64c
Compare
1a9f64c
to
5ac3060
Compare
Good catch! Added the null check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
our bubble map was keeping a reference to the bubble, stoping it from being destroyed. drop our reference when
destroy()
is emitted.Fixes: #212.