Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds drag support for the preview image in Save dialog #185

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

igordsm
Copy link
Contributor

@igordsm igordsm commented Jul 10, 2020

Closes #29 . There are still some pending questions about the interaction:

  1. should the dialog be closed after the dragging ends?
  2. this only works if the drop target supports images. As such, it does not work when dropping the image into Files or browsers. This limitation also exists with copy to clipboard (issue Copy to Clipboard wont allow to paste as file (direct on files) #156 )

As always, thank you for the hard work in Elementary.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this feature! I can confirm that this works with apps that accept pixbuf data like GIMP, for example.

I left a couple of inline comments with suggestions :)

We probably don't need to close the dialog if a drag is performed. Especially if the drop isn't successful this might lead to unexpected data loss

src/Widgets/SaveDialog.vala Outdated Show resolved Hide resolved
src/Widgets/SaveDialog.vala Outdated Show resolved Hide resolved
@igordsm igordsm requested a review from danirabbit July 13, 2020 21:55
@igordsm
Copy link
Contributor Author

igordsm commented Jul 13, 2020

@danrabbit Thank you for the suggestions. I have done as you said and re-requested a review.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for implementing this feature!

@danirabbit danirabbit merged commit 5eb496a into elementary:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and Drop from save dialog
2 participants