Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSettingsView: use AppInfo description #224

Merged
merged 2 commits into from
Mar 31, 2024
Merged

AppSettingsView: use AppInfo description #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7a905
AppSettingsView: use AppInfo description
danirabbit Mar 29, 2024
66379cf
Merge branch 'main' into danirabbit/appsettingsview-description
danirabbit Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Permissions/Backend/App.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public class Permissions.Backend.App : GLib.Object {
public Flatpak.InstalledRef installed_ref { get; construct; }
public string id { get; private set; }
public string name { get; private set; }
public string? description { get; private set; default = null; }
public Icon icon { get; private set; }
public GenericArray<Backend.PermissionSettings> settings;

Expand All @@ -41,6 +42,7 @@ public class Permissions.Backend.App : GLib.Object {
if (appinfo != null) {
name = appinfo.get_name ();
icon = appinfo.get_icon () ?? new ThemedIcon ("application-default-icon");
description = appinfo.get_description ();
} else {
icon = new ThemedIcon ("application-default-icon");
name = id;
Expand Down
1 change: 1 addition & 0 deletions src/Permissions/Widgets/AppSettingsView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ public class Permissions.Widgets.AppSettingsView : Switchboard.SettingsPage {

update_property (Gtk.AccessibleProperty.LABEL, _("%s permissions").printf (selected_app.name), -1);
title = selected_app.name;
description = selected_app.description;
icon = selected_app.icon;
}

Expand Down
Loading