Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointing: Vertical layout and cleanup #224

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Pointing: Vertical layout and cleanup #224

merged 4 commits into from
Jan 24, 2024

Conversation

danirabbit
Copy link
Member

  • Fix this layout using headerlabel etc
  • Code style
  • bump copyright header
  • mnemonic widget

Screenshot from 2024-01-23 15 44 02

@danirabbit danirabbit requested a review from a team January 23, 2024 23:47
jeremypw
jeremypw approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and everything works. Not sure of the significance of removing one of the `ally_keyboard_settings' binding but I trust this is not needed.

@danirabbit
Copy link
Member Author

@jeremypw it was setting sensitivity on a label that was removed :)

@danirabbit danirabbit merged commit 4870cff into main Jan 24, 2024
3 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/pointing-verticallayout branch January 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw