Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking: check active when toggled #243

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Clicking: check active when toggled #243

merged 1 commit into from
Aug 12, 2024

Conversation

danirabbit
Copy link
Member

toggled is sent whether the checkbutton becomes active or inactive. Check for active so we aren't hitting settings twice in a row for no reason

@danirabbit danirabbit requested a review from a team August 12, 2024 18:03
@lenemter lenemter merged commit f6b5aa7 into main Aug 12, 2024
2 of 4 checks passed
@lenemter lenemter deleted the danirabbit/clicking-toggledactive branch August 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @lenemter