Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddDialog: Gtk4 Prep #191

Merged
merged 1 commit into from
Oct 17, 2023
Merged

AddDialog: Gtk4 Prep #191

merged 1 commit into from
Oct 17, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 17, 2023 •
edited
Loading

Cherry from #164 plus fixes

  • Use Hdy.Window instead of Granite.Dialog. Fixes margins since we don't use any dialog functions and don't want the action area. Can replace with Gtk.Window in GTK4, same as Online Accounts dialogs
  • Code style
  • Use child property
  • replace shadow with frame
  • Replace grids with boxes
  • Vertical form layout with Granite.HeaderLabel for responsive
  • Use default size instead of size request
  • Replace buttonbox with box

@danirabbit danirabbit requested a review from a team October 17, 2023 21:55
@danirabbit danirabbit merged commit 2e415be into master Oct 17, 2023
4 checks passed
@danirabbit danirabbit deleted the danirabbit/adddialog-gtk4prep branch October 17, 2023 22:06
@danirabbit danirabbit mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @tintou