SettingsPage: Subclass Gtk.Widget #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
changed the title
|
@danirabbit I cannot compile elementary/switchboard-plug-bluetooth#216 even with this branch installed - what else do I need to do? Error is: |
|
I think it was renamed to |
|
Yup, just updated it! I ended up breaking API here a little harder than I though 😅 |
This was referenced Jan 26, 2024
jeremypw
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can test with elementary/switchboard-plug-bluetooth#216
Makes SettingsPage a Gtk.Widget instead of Gtk.Box so we're not exposing extra unwanted API and make it so settings a
childsets the content area child not overwrites the whole page. Also get rid of the separate simple page and abstract page, everything is only using the simple page. While we're here, clamp things!