Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsPage: use a header clamp, not sizegroup #308

Merged
merged 4 commits into from
May 19, 2024

Conversation

danirabbit
Copy link
Member

Fixes an issue where labels in the content area might not wrap. Can test with Applications settings

@danirabbit danirabbit requested a review from a team April 1, 2024 17:48
@danirabbit danirabbit mentioned this pull request May 9, 2024
3 tasks
@zeebok
Copy link
Contributor

zeebok commented May 19, 2024

Do you have an example application? When I test with what is currently on release in OS8, the application page seems to be unable to shrink smaller than the widgets within it, including labels. With this PR, it can now be resized to pretty much any size and does wrap text. So this does do what it should, and the code looks good, but wasn't fixing an issue I was seeing.

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and can confirm labels will wrap as expected. It also fixed an issue I saw in the Text settings where increasing font size would cause the slider and input to grow beyond what is visible in the window.

@danirabbit danirabbit merged commit 829249f into main May 19, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/settingspage-fixviewwrap branch May 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants