Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetAttr: fix recursive file owner changing + wrong group mark indicating + recursive file attributes/flags changing #2656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SetAttr: fix recursive file owner changing + wrong group mark indicating + recursive file attributes/flags changing #2656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
820401e
SetAttr: fix recursive file owner changing + wrong group mark indicating
spnethw Feb 3, 2025
a56cf93
SetAttr: fix recursive file attributes/flags changing
spnethw Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions far2l/src/setattr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ LONG_PTR WINAPI SetAttrDlgProc(HANDLE hDlg, int Msg, int Param1, LONG_PTR Param2
break;
case SA_COMBO_GROUP:
SetAttrDefaultMark(hDlg, SA_COMBO_GROUP-1, // mark (un)changed
IsEditChanged(hDlg, SA_COMBO_GROUP, DlgParam->strInitOwner) );
IsEditChanged(hDlg, SA_COMBO_GROUP, DlgParam->strInitGroup) );
break;
case SA_FIXEDIT_LAST_ACCESS_DATE:
SetAttrDefaultMark(hDlg, SA_FIXEDIT_LAST_ACCESS_DATE-1, // mark (un)changed
Expand Down Expand Up @@ -1651,7 +1651,7 @@ bool ShellSetFileAttributes(Panel *SrcPanel, LPCWSTR Object)
}
}

if (!ApplyFileOwnerGroupIfChanged(AttrDlg[SA_COMBO_GROUP], ESetFileOwner,
if (!ApplyFileOwnerGroupIfChanged(AttrDlg[SA_COMBO_OWNER], ESetFileOwner,
SkipMode, strFullName, DlgParam.strInitOwner,
DlgParam.OSubfoldersState))
break;
Expand Down Expand Up @@ -1700,8 +1700,8 @@ bool ShellSetFileAttributes(Panel *SrcPanel, LPCWSTR Object)
SkipMode = SETATTR_RET_SKIP;
continue;
}
ApplyFSFileFlags(AttrDlg, strFullName, FileAttr);
}
ApplyFSFileFlags(AttrDlg, strFullName, FileAttr);
}
}
}
Expand Down