-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New debug dump functionality #2660
Open
Dazzar56
wants to merge
8
commits into
elfmz:master
Choose a base branch
from
Dazzar56:debug_dump
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+177
−5
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d359141
initial version of debug dump
Dazzar56 6a991fb
debug dumper: escape special characters in strings
spnethw 2281eb5
Merge pull request #1 from spnethw/debug_dump
Dazzar56 59bae9f
debug dumper: refactor to handle all output at once
spnethw 4f17a7a
debug dumper: minor cleanup
spnethw aa046c7
debug dumper: add mutex
spnethw cdcdae5
debug dumper: logging string buffers using (pointer, length)
spnethw f1e0c2d
Merge pull request #3 from spnethw/debug_dump_handle_all_output_at_once
Dazzar56 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё-таки такая смена с 11 на 17 должна быть не постоянной, а только для
CMAKE_BUILD_TYPE
равное напримерDEBUGextend
, т.е. даём разрабам возможность дебажить по старинке в стандарте 11 и по новому в стандарте 17 имея риск, что, если применены новомодности, то потом при сборке релиза в стандарте 11 они боком вылезут.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ага, это первая из моих хотелок в тикете. Надо делать и сборку дампера и общий режим C++17 отключаемыми вместе.