Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab 110 - Ensure tests better asses if desired outcome has been reached #57

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

shayfaber
Copy link
Contributor

Changes

  • Most tests now have an additional check to ensure the desired outcome has actually been reached (or not!)
  • expects that asses if a notification is shown are now so called soft expects: the test will continue but mark the test. This is to ensure the additional check can still run.
  • Known issue for Firefox: The minicart button in the menu does not lose the "aria-disabled=true" flag when the first product is added to the cart, even after reload() and waitFor(). This prevents Playwright from opening the minicart and therefore continuing the test. Only consistently happens in UI mode, only when the first product gets added. Sometimes succeeds and sometimes fails when run from the terminal.

@shayfaber shayfaber requested a review from dheesen February 5, 2025 08:14
Copy link
Collaborator

@dheesen dheesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayfaber Tiny remark of, I think, missed soft expect.

@shayfaber shayfaber requested a review from dheesen February 5, 2025 09:13
@dheesen dheesen merged commit 3fe1694 into main Feb 5, 2025
1 check passed
@dheesen dheesen deleted the gitlab-110 branch February 5, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants