[feature] Mini CI para builds #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will lint all project files with eslint and stylelint. It will also run the webpack build. No tests are done yet so no test suite is being run.
Eslint and Stylelint both need a list of files to lint. The npm scripts run against a set of files. Webpack config now depends on env data being passed down from the CLI. This is so we can have both development and production configs in one same file.
Self hosted workflow will attempt to install packages, run both linters and then to produce a webpack build. In case any of these fails then the whole action status should reflect that it failed.
Eslint loads webpack to resolve modules and it doesn't set up environment variables. This makes devevelopment the default. Also ignore any files that might appear on the dist folder.
Since we are using a self-hosted machine now (that can build AND deploy way faster now), we no longer need a convoluted workflow. It also adds an image for ARM64 (there's probably a better way for this). In the future this can also build for x86.
This new event runs workflow at base instead of the merge commit. Which means we can run a safe workflow against pull request code.
Since we are using a rPIv4 it's much faster to run it on ARM64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discutido en #11 agrego un workflow para CI (para ver si alguna build falla al momento de subir más que nada). También mueve el workflow de los equipos de Github.