Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addding relocation type for PPC 32 EABI #532

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

rajez133
Copy link
Contributor

No description provided.

Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a minor request

elftools/elf/descriptions.py Outdated Show resolved Hide resolved
@sevaa
Copy link
Contributor

sevaa commented Apr 16, 2024

@rajez133 are you still interested in this?

@sevaa
Copy link
Contributor

sevaa commented Apr 18, 2024

@eliben Requested changes were provided, I think.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sevaa
Copy link
Contributor

sevaa commented Sep 23, 2024

@eliben required changes were provided, no?

@eliben
Copy link
Owner

eliben commented Sep 23, 2024

@sevaa
Yes

this LGTY?

@sevaa
Copy link
Contributor

sevaa commented Sep 23, 2024

I didn't check the changes against the ABI. and I don't have a binary to test this against, so I'd take the OP's word on it. The code looks in line with the rest of the library.

@eliben eliben merged commit c03e7e6 into eliben:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants