Pub year volume #13
Pub year volume #13
Conversation
| return { | ||
| doi: expression.embodimentOf.doi, | ||
| volume: expression.embodimentOf.volumeIdentifier, | ||
| eLocationId: expression.embodimentOf.electronicArticleIdentifier, |
There was a problem hiding this comment.
expression.embodimentOf.doi, expression.embodimentOf.doi and expression.embodimentOf.electronicArticleIdentifier are optional. We should expand the tests to account for this. This feels like it might fail or not return the expect value if one of the embodimentOf properties was not set.
There was a problem hiding this comment.
We did add a test to account for one of the props being empty. This resulted in a failing test, because it was retuning undefined for all props, so we expanded the updating of the manuscript data to only set values when the value is truthy. Is this what you wanted to cover? The values returned in this function are only used there, never directly returned to the calling user.
| } |
There was a problem hiding this comment.
These changes should be removed or we should regenerate the the examples?
relates to https://github.com/elifesciences/enhanced-preprints-issues/issues/768