Added support for corrected assertions in docmap #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented parsing and generation of corrected assertions in docmap. Tests and fixtures were updated to verify this new feature. An additional correctedDate field was added to preprints and reviewed preprints. A new corrected status was also added to AssertionStatus.
Improve readability by splitting imports from 'docmap-generators' into separate lines.
scottaubrey
previously approved these changes
Jun 20, 2024
…preprints-issues#1120] Update the correction structure in the docmap-parser and its test cases. Now, instead of an array of dates, the 'corrections' field holds an array of objects with a 'correctedDate' field.
…ues#1120] Update a comment in the docmap-parser to accurately reflect the function's purpose. It now states 'Update preprint with corrections'.
…prints-issues#1120] Update test and fixture in docmap parser to check for corrections on a published version of record. Test and fixture names have been changed to reflect this update.
…enhanced-preprints-issues#1120] In the docmap-parser and its corresponding test file, a new 'content' field has been added to the 'Correction' type. This field is populated with the URLs of the corrected versions of records.
…reprints-issues#1120] Refactored the way content is filtered in the docmap-parser. Previous method used a filter then map combination, but it has been replaced with a more efficient reduce method. This enhancement is specifically for the parsing of 'web-page' type content with valid URLs.
…d-preprints-issues#1120] This commit introduces a new function, getPublishedOutput, in docmap-parser. This function checks the length of preprintOutputs and versionOfRecordOutputs and returns the first item if there's one, otherwise it returns false. The existing function getPublishedVersionOfRecord has been updated to use the newly implemented getPublishedOutput function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented parsing and generation of corrected assertions in docmap. Tests and fixtures were updated to verify this new feature. An additional correctedDate field was added to preprints and reviewed preprints. A new corrected status was also added to AssertionStatus.