Skip to content

Commit

Permalink
Rename a method for consistency with similar classes
Browse files Browse the repository at this point in the history
  • Loading branch information
LinaKind committed Jan 8, 2025
1 parent 1b85b69 commit d9e81d1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Controller/ArticlesController.php
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ private function createFirstPage(Request $request, string $id, array $arguments)
null,
null,
null,
$assessmentBuilder->createAssessment($elifeAssessment)
$assessmentBuilder->build($elifeAssessment)
);
}
});
Expand Down
2 changes: 1 addition & 1 deletion src/ViewModel/Converter/AssessmentBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AssessmentBuilder
'inadequate' => 'Methods, data and analyses do not support the primary claims',
];

final public function createAssessment(ArticleSection $elifeAssessment): Assessment {
final public function build(ArticleSection $elifeAssessment): Assessment {
$summary = 'During the peer-review process the editor and reviewers write an eLife Assessment that summarises the significance of the findings reported in the article (on a scale ranging from landmark to useful) and the strength of the evidence (on a scale ranging from exceptional to inadequate). <a href="https://elifesciences.org/about/elife-assessments">Learn more about eLife Assessments</a>';
$significanceTerms = ['Landmark', 'Fundamental', 'Important', 'Valuable', 'Useful'];
$strengthTerms = ['Exceptional', 'Compelling', 'Convincing', 'Solid', 'Incomplete', 'Inadequate'];
Expand Down
2 changes: 1 addition & 1 deletion test/ViewModel/Converter/AssessmentBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ private function getTestResult(string $contentText)
$doi = '10.7554/eLife.94242.3.sa0';
$id = 'sa0';
$elifeAssessment = new ArticleSection($content, $doi, $id);
return $assessmentBuilder->createAssessment($elifeAssessment);
return $assessmentBuilder->build($elifeAssessment);
}

private function assertHasSignificance(string $term, Assessment $result)
Expand Down

0 comments on commit d9e81d1

Please sign in to comment.