Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor content twig file for grid framework #1594

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

discodavey
Copy link
Member

No description provided.

@nlisgo
Copy link
Member

nlisgo commented Mar 31, 2022

I can help with the failing tests if you need it. Not sure why the white space is being introduced based on the changes coming in but if you are happy with the whitespaces being there then we should improve the tests so that it passes with or without the whitespaces.

@discodavey
Copy link
Member Author

I think it's weird that the tests are failing. Did they ever work before?

Do we need the whitespaces? If not then we can remove them.

@nlisgo
Copy link
Member

nlisgo commented Mar 31, 2022

I think it's weird that the tests are failing. Did they ever work before?
Do we need the whitespaces? If not then we can remove them.

The tests worked before because there was no whitespace before. If you wish to remove the whitespace then we will need to do more work in pattern library to eliminate the whitespace. Or we need to make the test work with or without the whitespace. However, since this is just a demo to determine if fit for release then we could just quickly suppress the tests to be able to deploy the demo instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants