Converting framework to cssgrids #1084
Conversation
|
@davidcmoulton Could you cast your eye over the code changes pleases. I have put the grid throughout the site now. Comments would be good if possible on here or verbally. |
|
@davidcmoulton When you look at this I have done the changes to the Homepage and Research Article pages in the Pattern Library. |
| justify-content: center; | ||
| margin: auto; | ||
| padding: 0 12px; | ||
| @include constrain-width(1104, "max"); |
nlisgo
force-pushed
the
converting-framework-to-cssgrids
branch
from
b9218f9 to
9ff42c8
Compare
…/elifesciences/pattern-library into converting-framework-to-cssgrids
assets/js/components/AssetViewer.js
Outdated
| @@ -84,19 +84,19 @@ module.exports = class AssetViewer { | |||
| if (!this.loader) { | |||
| this.loader = Promise.all([ | |||
| utils.loadJavaScript( | |||
| 'https://cdnjs.cloudflare.com/ajax/libs/photoswipe/4.1.3/photoswipe.min.js', | |||
| 'https://cdnjs.cloudflare.com/ajax/libs/photoswipe/4.1.2/photoswipe.min.js', | |||
There was a problem hiding this comment.
Any reason why this library is being downgraded?
There was a problem hiding this comment.
These changes have come in from updating from last September to current. Not sure why this has been downgraded but will update again
assets/js/components/ViewSelector.js
Outdated
| @@ -38,6 +37,9 @@ module.exports = class ViewSelector { | |||
| return; | |||
| } | |||
|
|
|||
| // matches top padding in scss | |||
| let topSpaceWhenFixed = 30; | |||
There was a problem hiding this comment.
Should be const if the value doesn't change
There was a problem hiding this comment.
As above these have been brought in from the update from when we last updated last year. But yes agree. It should be const
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "type": "git", | |||
| "url": "https://github.com/elifesciences/pattern-library" | |||
| }, | |||
| "version": "0.0.7", | |||
| "version": "0.0.6", | |||
There was a problem hiding this comment.
Why have you changed this?
There was a problem hiding this comment.
As above. Will change as from updates
| <ul class="social-links__list"> | ||
| <li class="social-links__list_item"> | ||
| <a href="https://twitter.com/elife" class="social-links__list_link" aria-label="Twitter"> | ||
| <svg width="28" height="28"> |
There was a problem hiding this comment.
Any reason why these SVG images aren't stored in separate files?
No description provided.