Skip to content

Commit

Permalink
remove remaining mentions of gearman and workers (#526)
Browse files Browse the repository at this point in the history
  • Loading branch information
scottaubrey authored Oct 9, 2024
1 parent 4d490d3 commit 5100d45
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 25 deletions.
7 changes: 0 additions & 7 deletions bin/ci-process-bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ interrupt_fn() {
set +e
echo "Performing cleanup..."

if [ -n "$workerPid" ]; then
if ps -p "$workerPid" > /dev/null; then
echo "Worker is still running. Terminating..."
kill "$workerPid"
fi
fi

if [ -n "$queueWatchPid" ]; then
if ps -p "$queueWatchPid" > /dev/null; then
echo "Watcher is still running. Terminating..."
Expand Down
8 changes: 3 additions & 5 deletions bin/wait-for-empty-queues
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
#!/usr/bin/env bash
set -e

# with just a single worker the polling may fail often as there is a gap between accepting and completing a job.
# with more workers this becomes less unlikely.
# more workers also means more CPU usage which means less CPU available for serving traffic.

# same again, but for the sqs watcher
# with just a single sqs watcher the polling may fail often as there is a gap between accepting and completing a job.
# with more sqs watchers this becomes less unlikely.
# more sqs watchers also means more CPU usage which means less CPU available for serving traffic.
num_watches_threshold=100 # 100 attempts with a .10s interval is 10 seconds
num_watches_attempt=0

Expand Down
1 change: 0 additions & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ services:
dockerfile: Dockerfile
target: dev
environment:
- GEARMAN_HOST=gearman
- GATEWAY_HOST=api-dummy:8080
volumes:
- ./:/app
Expand Down
2 changes: 1 addition & 1 deletion src/Search/Api/Elasticsearch/Command/BuildIndexCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protected function configure()
->setDescription('Ensure Elasticsearch has been setup <comment>WARNING: DROPS CONTENT WITH -d</comment>')
->addOption('delete', 'd', InputOption::VALUE_NONE, 'Drop content')
->addOption('index', 'i', InputOption::VALUE_OPTIONAL, 'Index that should be (re)created')
->setHelp('Creates new Gearman client and imports entities from API');
->setHelp('Ensures Elasticsearch has been setup');
}

protected function execute(InputInterface $input, OutputInterface $output)
Expand Down
11 changes: 0 additions & 11 deletions tests/bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,3 @@
*
* This contains SHIMs for certain classes.
*/

// @todo fix autoloading
namespace {
if (!class_exists('GearmanClient')) {
class GearmanClient
{
}

define('GEARMAN_SUCCESS', 'GEARMAN_SUCCESS');
}
}

0 comments on commit 5100d45

Please sign in to comment.