Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter, and git make my day and i delete all my work) #16

Closed
wants to merge 3 commits into from

Conversation

saharulik
Copy link
Contributor

@saharulik saharulik commented Mar 31, 2024

Summary by CodeRabbit

  • New Features
    • Introduced a point counting feature in chat interactions to enhance user engagement.
    • Added a progress indicator in the chat screen top bar with custom styling and colors.
    • Included a new color constant Gold80 with the value 0xFFFFC94A.

Copy link

coderabbitai bot commented Mar 31, 2024

Walkthrough

The update introduces a new feature in the chat functionality, specifically within the ChatViewModel class. A pointCounter variable has been added to keep track of certain metrics or actions performed during chat sessions. This variable, which is of type Float, dynamically changes based on specific conditions encountered during the chat interactions. Additionally, a LinearProgressIndicator has been added to the ChatScreen for displaying progress, and a new color constant Gold80 has been defined in the color theme.

Changes

File Path Change Summary
.../feature/chat/ChatViewModel.kt &
.../feature/chat/ChatUiState.kt
Added a pointCounter variable of type Float in ChatViewModel.kt and inserted a logging statement in ChatUiState.kt.
.../feature/chat/ChatScreen.kt Added a LinearProgressIndicator for displaying progress in the chat screen with custom styling and colors.
.../ui/theme/Color.kt Added a new color constant Gold80 with the value 0xFFFFC94A.
settings.gradle.kts Updated settings.gradle.kts to remove the assignment of rootProject.name to "Soga" and explicitly include the module ":app".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@saharulik saharulik requested a review from jo-elimu March 31, 2024 09:36
@@ -57,6 +62,7 @@ class ChatViewModel(
isPending = false
)
)
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.contains("correct") || modelResponse.contains("Correct")) { pointCounter += 0.1f }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.contains("correct") || modelResponse.contains("Correct")) { pointCounter += 0.1f }
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.toLowerCase().contains("that's correct") || modelResponse.toLowerCase().contains("correct!") || modelResponse.toLowerCase().contains("fantastic!") || modelResponse.toLowerCase().contains("that's right")) { pointCounter += 0.1f }

Copy link
Member

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested more variations of "Correct"

@@ -18,6 +19,7 @@ class ChatUiState(
val newMessage = lastMessage.apply { isPending = false }
_messages.removeLast()
_messages.add(newMessage)
Log.i("Mytag","ChatUiState")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging statement uses a generic tag "Mytag" and a static message, which might not provide sufficient context for debugging. Consider using a more descriptive tag and including dynamic information relevant to the operation or state, such as the message ID or type being replaced. Additionally, ensure that logging at this level is necessary and does not impact the application's performance or leak sensitive information.

- Log.i("Mytag","ChatUiState")
+ Log.i("ChatUiState", "Replacing last pending message with ID: ${newMessage.id}")

Note: Adjust the logging message as appropriate to include relevant dynamic information.


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Log.i("Mytag","ChatUiState")
Log.i("ChatUiState", "Replacing last pending message with ID: ${newMessage.id}")

@saharulik saharulik closed this Aug 22, 2024
@saharulik saharulik deleted the need-to-restore-progress-bar branch August 22, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants