-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counter, and git make my day and i delete all my work) #16
Conversation
WalkthroughThe update introduces a new feature in the chat functionality, specifically within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -57,6 +62,7 @@ class ChatViewModel( | |||
isPending = false | |||
) | |||
) | |||
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.contains("correct") || modelResponse.contains("Correct")) { pointCounter += 0.1f } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.contains("correct") || modelResponse.contains("Correct")) { pointCounter += 0.1f } | |
if (modelResponse.contains("\uD83C\uDF1F") || modelResponse.toLowerCase().contains("that's correct") || modelResponse.toLowerCase().contains("correct!") || modelResponse.toLowerCase().contains("fantastic!") || modelResponse.toLowerCase().contains("that's right")) { pointCounter += 0.1f } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested more variations of "Correct"
@@ -18,6 +19,7 @@ class ChatUiState( | |||
val newMessage = lastMessage.apply { isPending = false } | |||
_messages.removeLast() | |||
_messages.add(newMessage) | |||
Log.i("Mytag","ChatUiState") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logging statement uses a generic tag "Mytag" and a static message, which might not provide sufficient context for debugging. Consider using a more descriptive tag and including dynamic information relevant to the operation or state, such as the message ID or type being replaced. Additionally, ensure that logging at this level is necessary and does not impact the application's performance or leak sensitive information.
- Log.i("Mytag","ChatUiState")
+ Log.i("ChatUiState", "Replacing last pending message with ID: ${newMessage.id}")
Note: Adjust the logging message as appropriate to include relevant dynamic information.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Log.i("Mytag","ChatUiState") | |
Log.i("ChatUiState", "Replacing last pending message with ID: ${newMessage.id}") |
Summary by CodeRabbit
Gold80
with the value0xFFFFC94A
.