-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the confoguration of the mongodb host, adds flexibility to the … #113
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to configure the MongoDB host by adding a new environment variable MONGO_HOST. The changes include updates to the update-config-map.sh script to handle the new variable and modifications to the Kubernetes job template to pass this variable. This enhancement adds flexibility to the chart configuration. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lvarin - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Check for potential injection vulnerabilities. (link)
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
a8e6c97
to
fc6170e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…chart
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Summary by Sourcery
This pull request introduces the ability to configure the MongoDB host via an environment variable, enhancing the flexibility of the deployment configuration.