Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the confoguration of the mongodb host, adds flexibility to the … #113

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jul 11, 2024

…chart

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request introduces the ability to configure the MongoDB host via an environment variable, enhancing the flexibility of the deployment configuration.

  • New Features:
    • Added the ability to configure the MongoDB host through an environment variable in the update-config-map.sh script.
  • Enhancements:
    • Updated the trs-filer-configmap-job.yaml to include the MONGO_HOST environment variable, allowing for dynamic MongoDB host configuration.

@lvarin lvarin requested a review from trispera July 11, 2024 06:16
Copy link

sourcery-ai bot commented Jul 11, 2024

Reviewer's Guide by Sourcery

This pull request introduces the ability to configure the MongoDB host by adding a new environment variable MONGO_HOST. The changes include updates to the update-config-map.sh script to handle the new variable and modifications to the Kubernetes job template to pass this variable. This enhancement adds flexibility to the chart configuration.

File-Level Changes

Files Changes
update-config-map.sh
deployment/templates/trs-filer-configmap-job.yaml
Introduced the ability to configure the MongoDB host by adding a new environment variable MONGO_HOST and updating the relevant scripts and templates to use this variable.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvarin - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Check for potential injection vulnerabilities. (link)
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

update-config-map.sh Show resolved Hide resolved
update-config-map.sh Show resolved Hide resolved
update-config-map.sh Show resolved Hide resolved
update-config-map.sh Outdated Show resolved Hide resolved
lvarin added 2 commits July 11, 2024 11:00
# This is the 1st commit message:

Update update-config-map.sh

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
# The commit message #2 will be skipped:

# Fix wrong review

# The commit message #3 will be skipped:

# Fix if
@lvarin lvarin force-pushed the allow-mongodb-host-config branch from a8e6c97 to fc6170e Compare July 11, 2024 08:01
Copy link
Member

@trispera trispera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trispera trispera merged commit c65300a into dev Jul 11, 2024
1 of 4 checks passed
@trispera trispera deleted the allow-mongodb-host-config branch July 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants