Add prefix support to renaming indices #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * When using [triplex](https://github.com/ateliware/triplex) or similar for multi-tenancy with query prefixes, renaming _tables_ within a tenant is supported, but renaming an index was not. For example: `rename table(:foo), to: table(:bar)` works `rename index(:tablename, [:columns], name: "old_index_name"), to: "new_index_name"` This change addresses the need by: * Making indices similarly prefix-aware as tables.
PaulOstazeski
commented
Jan 23, 2025
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
When using triplex or similar
for multi-tenancy with query prefixes, renaming tables within a
tenant is supported, but renaming an index was not. For example:
rename table(:foo), to: table(:bar)worksrename index(:tablename, [:columns], name: "old_index_name"), to: "new_index_name"failsThis change addresses the need by:
Not addressed:
:tooption forrename/2varies. Whenrenaming a table,
:toexpects a%Table{}, when renaming an index, a stringis expected.