Fix decimal empty list bug #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were generating values that the Rust side couldn't handle.
Sometimes this decode failure happens because Elixir Decimals can hold a wider range of values than Rust (Arrow) Decimals. Here, we're giving a hint about why the decode may have failed.
The bug turned out to be that in the presence of empty lists, we weren't casting when we should have been.
After restricting the decimal generator such that it only produced valid Decimals and fixing the empty list bug, it now seems like it's safe to include decimals in the property tests.
josevalim
approved these changes
Nov 14, 2024
|
Also worth noting: EDIT: contents moved to their own issue: #1016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two things:
:decimalgenerator was generating Elixir-side#Decimal<>s that the Rust-side couldn't represent.s_from_list_decimalwhere empty lists failed to have theDecimal(...)dtype.Now we can remove the decimal-related TODOs we added in #1012.
See also: #1014.