Use coef: i128 in decimal
#1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were using `coef: u64` as that was the largest type that was also guarunteed to be positive. This left half the bits unused, however. This change makes it so we're using all available bits. Even though technically we could make an invalid ExDecimal after this change, it's not a practical concern.
This reverts an old change that was a work around for the `coef: u64` thing.
josevalim
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our
ExDecimalrepresentation to:This gives us the ability to represent larger decimals. The trade-off is we could technically create an invalid
ExDecimalin our Rust code. But I don't think it's a practical concern: we just need to be careful to always call.abs()when we instantiate it.