Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re_contains/2 and re_replace/3 to match with a regex #894

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

philss
Copy link
Member

@philss philss commented Apr 14, 2024

The regular expression must follow the regex crate rules, and should be a string.

The idea of keeping them separate is because we cannot use the Elixir standard regex, and we need to use strings for both literal and regex versions. To make the difference explicit, we are using the re_ prefix for functions that accept regexes as strings.

This is related to #353

The regular expression must follow the `regex` crate rules, and should
be a string.

The idea of keeping them separate is because we cannot use the Elixir
standard regex, and we need to use strings for both literal and regex
versions. To make the difference explicit, we are using the `re_` prefix
for functions that accept regexes as strings.

This is related to #353
lib/explorer/series.ex Outdated Show resolved Hide resolved
@philss philss merged commit 716f498 into main Apr 14, 2024
4 checks passed
@philss philss deleted the ps-add-re-string-funs branch April 14, 2024 17:44
@philss philss mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants