Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies and fixed build #9

Merged
merged 4 commits into from
Mar 18, 2015
Merged

updated dependencies and fixed build #9

merged 4 commits into from
Mar 18, 2015

Conversation

remojansen
Copy link
Contributor

I was investigating the failing unit testing that was breaking the build. I ended up asking on stackoverflow:

http://stackoverflow.com/questions/28956295/estrange-behaviour-in-javascript-array-clone-equality-assertion

We can't use contain our include here:

arrContainer.should.not.contain(objNeedle); // fails
arrContainer.should.not.include(objNeedle); // fails

Because when looking for an object inside an array chai will use deep equality.

@remojansen remojansen closed this Mar 10, 2015
@remojansen remojansen reopened this Mar 10, 2015
elliotf added a commit that referenced this pull request Mar 18, 2015
updated dependencies and fixed build
@elliotf elliotf merged commit f0254fd into elliotf:master Mar 18, 2015
@elliotf
Copy link
Owner

elliotf commented Mar 18, 2015

Published v1.5.0

@elliotf
Copy link
Owner

elliotf commented Mar 18, 2015

Thank you, @remojansen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants