Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make note visible #113

Closed

Conversation

sokratis1988
Copy link
Contributor

fixes #70

Shows notes in dashboard if note exist for subscription

wallos_70

@ellite
Copy link
Owner

ellite commented Feb 12, 2024

Hi, thank you very much for the contribution.
I already have some work on showing the notes. Because of the mobile view it's a bit different idea.

The other PR's seem to be mixed and very confused. Would appreciate if you could separate them and only add one feature / fix per PR. Would make it much easier to understand and merge.

About the Disabled subscriptions:

  • The default state of a subscription should be already enabled. So the new field should be "disabled".
  • The createdatabase.php should not be changed. The migration system should be used instead (please check: includes/migrations/)

Thank you again.

@sokratis1988
Copy link
Contributor Author

Sure! Just close this PR if not fit with your idea.
Pull Request #112 exclusively introduces the feature for inactive subscriptions (now).

  • By default, subscriptions are active, which is why the form displays the checkbox as selected to avoid confusion.
  • I have withdrawn the modifications made to createdatabase.php and have adjusted the default value in the database to true, as specified in the migration file 000006.php.
  • endpoints/cronjobs/sendnotifications.php: Disable notifications for inactive subscriptions
  • endpoints/cronjobs/updatenextpayment.php: Ensure only subscriptions that are active will be updated
  • endpoints/subscription/add.php: Update statements and add field activated
  • endpoints/subscription/get.php: Add field activated
  • endpoints/subscriptions/get.php: Add field activated
  • includes/i18n/*.php: Update languages
  • includes/list_subscriptions.php: Add usort to put inactive subscriptions on bottom and update css class based on status to decorate the inactive subscriptions
  • index.php: Add field and checkbox in form with checked state on new creation
  • migrations/000006.php: create migration to update database
  • scripts/dashboard.js: add const for new field activated
  • stats.php: inactive subscriptions will be omitted from the overall statistics; new statistic for inactive subscriptions
  • styles/styles.css: css for inactive subscriptions

@ellite
Copy link
Owner

ellite commented Feb 18, 2024

Notes and the misc fixes are now implemented and merged. Thank you.
Closing this one.

@ellite ellite closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Make notes visible
2 participants