Implemented reading scripts from stdin #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample
As you can see, stdin can't be read from. A really hacky solution could be to try to re-open stdin but maybe we don't wanna do that. |
|
Tests! I feel so ashamed! See also ca6473d. I took a roughly similar approach, but with the file mode check. |
Fixes ellotheth#1. This PR starts the ability to read from stdin. The main problem though is that os.Stdin is consumed for the script body's read and EOF encountered. This means that we won't have interactive input.
odeke-em
force-pushed
the
implement-stdin-reading
branch
from
b50d080 to
137a1d4
Compare
|
Turns out I hadn't committed my last changes as I was multi tasking abit. Please refresh and take a look. |
|
Implemented by #8. Thanks @ellotheth. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.
This PR starts the ability to read from stdin.
The main problem though is that os.Stdin is consumed
for the script body's read and EOF encountered.
This means that we won't have interactive input.
Just to let you know there is a method script.Piped() that could potentially be useful in handling the non-interactiveness after EOF on stdin is encountered.
It is currently a work in progress so that I don't forget about it. Please feel free to copy the code, discard it or modify it.
Cheers!