Skip to content

Commit

Permalink
OvmfPkg: Remove applicationProcessorEntryPoint
Browse files Browse the repository at this point in the history
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494

Current reset vector uses 0xffffffe0 as AP waking vector, and expects
GenFv generates code aligned on a 4k boundary which will jump to this
location. However, some issues are listed below
1. GenFV doesn't generate code as the comment expects, because GenFv
assumes no modifications are required to the VTF-0 'Volume Top File'.
2. Even if removing VFT0 signature and let GenFv to modify, Genfv is
hard-code using another flash address 0xffffffd0.
3. In the same patch series, AP waking vector code is removed from
GenFv, because no such usage anymore. The existing of first two issues
also approve the usage is not available for a long time.

Therefore, remove AP waking vector related code.

Cc: Ard Biesheuvel <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Anthony Perard <[email protected]>
Cc: Julien Grall <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Acked-by: Anthony PERARD <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
  • Loading branch information
LiuZhiguang001 authored and mergify[bot] committed Sep 18, 2023
1 parent 718cf21 commit dea6002
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 25 deletions.
15 changes: 3 additions & 12 deletions OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm
Original file line number Diff line number Diff line change
Expand Up @@ -160,22 +160,13 @@ guidedStructureEnd:

ALIGN 16

applicationProcessorEntryPoint:
;
; Application Processors entry point
; 0xffffffe0
;
; GenFv generates code aligned on a 4k boundary which will jump to this
; location. (0xffffffe0) This allows the Local APIC Startup IPI to be
; used to wake up the application processors.
;
jmp EarlyApInitReal16

ALIGN 8

DD 0
DD 0, 0, 0

;
; The VTF signature
; The VTF signature (0xffffffec)
;
; VTF-0 means that the VTF (Volume Top File) code does not require
; any fixups.
Expand Down
16 changes: 3 additions & 13 deletions OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,13 @@ xenPVHEntryPoint:

BITS 16
ALIGN 16

applicationProcessorEntryPoint:
;
; Application Processors entry point
;
; GenFv generates code aligned on a 4k boundary which will jump to this
; location. (0xffffffe0) This allows the Local APIC Startup IPI to be
; used to wake up the application processors.
; 0xffffffe0
;
jmp EarlyApInitReal16

ALIGN 8

DD 0
DD 0, 0, 0

;
; The VTF signature
; The VTF signature (0xffffffec)
;
; VTF-0 means that the VTF (Volume Top File) code does not require
; any fixups.
Expand Down

0 comments on commit dea6002

Please sign in to comment.