Skip to content

Commit

Permalink
UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception
Browse files Browse the repository at this point in the history
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4360

An incorrect format specifier is being used in a DEBUG print,
specifically, a variable of type EFI_STATUS was being printed with
the %a format specifier (pointer to an ASCII string), thus the value of
the Status variable was being treated as the address of a string,
leading to a CPU exception, when encountered this bug manifests itself
as a hang near "Ready to Boot Event", with the last DEBUG print being
"INFO: Got MicrocodePatchHob with microcode patches starting address"
followed by a CPU Exception dump.

Signed-off-by: Darbin Reyes <[email protected]>
Reviewed-by: Jacob Narey <[email protected]>
Reviewed-by: Michael D Kinney <[email protected]>
Reviewed-by: Eric Dong <[email protected]>
  • Loading branch information
darbin-reyes authored and mergify[bot] committed Mar 10, 2023
1 parent 4ca4041 commit fd1820b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ MeasureMicrocodePatches (
TotalMicrocodeSize)
);
} else {
DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %a!\n", Status));
DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %r!\n", Status));
}

FreePool (Offsets);
Expand Down

0 comments on commit fd1820b

Please sign in to comment.