Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSS variables in fill and stroke #49

Merged
merged 4 commits into from
Jan 25, 2021

Conversation

francescortiz
Copy link

I added support for css variables in fill and stroke. They should be applied everywhere, but this is the use case I faced and also the one mentioned in this issue:

#39

@rupertlssmith rupertlssmith merged commit ba94477 into elm-community:master Jan 25, 2021
@rupertlssmith
Copy link
Contributor

Let me know if you urgently need a new version published with this - its a breaking change so will bump the major version.

@rupertlssmith
Copy link
Contributor

rupertlssmith commented Jan 25, 2021

Also worth noting, as discussed on issue #18, it can be worth documenting features that are not SVG 1.1. compliant. SVG in the browser is a mash-up of SVG 1.1 and CSS, so CSS features could potentially catch someone out who is trying to generate some SVG 1.1 compliant output (maybe to export the SVG to Inkscape for example).

The approach settled on in issue #18 is just to document these things, so maybe a note on the docs for type Paint to say that CSSVariable is not SVG 1.1 compliant could be nice?

@francescortiz
Copy link
Author

Let me know if you urgently need a new version published with this - its a breaking change so will bump the major version.

No need to, thanks.

The approach settled on in issue #18 is just to document these things, so maybe a note on the docs for type Paint to say that CSSVariable is not SVG 1.1 compliant could be nice?

Agreed. I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants