-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial README #11
base: master
Are you sure you want to change the base?
Initial README #11
Conversation
Hey, why are we writing off "Revisiting various aspects of Signal and Mailbox" until a later release? It seems to have popular support and the implementation is simple. If you're worried it's not the right idea, then all the more reason to add it now - that's more time to build on it or undo the change. Otherwise looks good. |
f7ab593
to
5a5372d
Compare
That reasoning makes sense to me, but ultimately it's up to @evancz 😃 |
See the [list of Closed Proposals](https://github.com/elm-lang/elm-plans/issues?utf8=%E2%9C%93&q=is%3Aclosed+is%3Aissue+label%3Aproposal+). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed proposals might not be decided against, but rather implemented and merged, no? Maybe another label is needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to remove the proposal
label for proposals that get accepted and completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense to have tags like: accepted, rejected, awaiting more data
in addition to the proposal label. Even if one of those things happens, it's still a proposal. Is the assumption that everything here is a proposal though? If so, maybe that's a weird tag to have? Are there other categories of issue we expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair points.
I can see rejected
, although I'd prefer a friendlier term like declined
.
Let's keep everything with the proposal
label for now; it's easy enough to remove them later if they turn out to be redundant, but more error-prone to introduce them on a case-by-case basis if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://waffle.io/ could be used to visualize the states of these, and
make it easy for you to drag and drop them between states.
Evan Czaplicki writes:
\ No newline at end of file
+See the list of Closed Proposals.Maybe it makes sense to have tags like: accepted, rejected, awaiting more data
in addition to the proposal label. Even if one of those things happens, it's still a proposal. Is the assumption that everything here is a proposal though? If so, maybe that's a weird tag to have? Are there other categories of issue we expect?
Reply to this email directly or view it on GitHub:
https://github.com/elm-lang/elm-plans/pull/11/files#r34932943
Kyle Marek-Spartz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dude great idea! I'll look into it. I think we'd still want a way to distill messaging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it just uses labels for columns, so it should map pretty easily.
Via elm/compiler#993: |
Fleshed out the README a bunch.