User-friendly method names #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangelMaxime
previously approved these changes
Dec 28, 2023
|
The issue was about documenting the existing methods, not obsoleting them.
I already rejected the renames, as long as the motivation is just the
personal preference it might as well be my personal preference.
|
There was a problem hiding this comment.
Re-reading the issue, the proposition was to use doc comments on the functions.
People can create a library on top of the urlParse to provide different helpers kinda like done with Thoth.Json.
Using long name, makes the parser less compass and feel less like a URL
|
Understood. I'll abandon this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27