Skip to content

Commit

Permalink
Use PolySharp for automatic polyfilling (#5161)
Browse files Browse the repository at this point in the history
* Remove unnecessary whitespace in packages.yml

The whitespace after the if conditional in packages.yml was unused and unnecessary. This commit ensures to remove those to promote cleaner, more efficient code.

* Update default package version in GitHub workflows

The package version in the GitHub workflows configuration (.github/workflows/packages.yml) has been updated from 3.1.0 to 3.2.0. This change reflects version updates in the package management system.

* Use PolySharp for automatic polyfilling

PolySharp is a design time only dependency which will analyze which polyfills are needed for the currently building target framework and will then source generate only the needed polyfills. Also they're internal by default so they don't conflict.

fixes #5157

---------

Co-authored-by: Sipke Schoorstra <[email protected]>
  • Loading branch information
Suchiman and sfmskywalker authored Apr 2, 2024
1 parent b4f5797 commit 2f6e579
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
1 change: 1 addition & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
<PackageVersion Include="Nuke.Components" Version="8.0.0"/>
<PackageVersion Include="Open.Linq.AsyncExtensions" Version="1.2.0"/>
<PackageVersion Include="Polly.Extensions.Http" Version="3.0.0"/>
<PackageVersion Include="PolySharp" Version="1.14.1"/>
<PackageVersion Include="Proto.Actor" Version="1.5.0"/>
<PackageVersion Include="Proto.Cluster" Version="1.5.0"/>
<PackageVersion Include="Proto.Cluster.CodeGen" Version="1.5.0"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>
Expand All @@ -10,6 +10,10 @@
<ItemGroup>
<PackageReference Include="Humanizer.Core" />
<PackageReference Include="IronCompress" />
<PackageReference Include="PolySharp">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Linq.Dynamic.Core" />
</ItemGroup>

Expand Down
8 changes: 0 additions & 8 deletions src/modules/Elsa.Workflows.Management/RequiredMembers.cs

This file was deleted.

0 comments on commit 2f6e579

Please sign in to comment.