Fix corfu--teardown signature (backward compatible)
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new commit in `corfu` changes the signature of `corfu--teardown`, this PR fixes that. ## Ref emacs-evil#767 (comment)
russmatney
added a commit
to russmatney/dotfiles
that referenced
this pull request
Jan 3, 2024
My copy-pasta-ed corfu setup needed an update - corfu--setup and --teardown now handle areguments - these funcs can't be applied because evil-normalize-keymaps does not expect args. The resulting behavior is a pain - stuck in insert mode, need to M-x evil-force-normal-state to get out. The fixes have already been made in evil-collection, so we update that pin to the latest and drop some unnecessary code from corfu/config.el. (ref: emacs-evil/evil-collection#769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new commit in
corfuchanges the signature ofcorfu--teardown, this PR fixes that.References
corfu--setupsignature (backward compatible) #767 (comment)