Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf: implement evil yank to registers #795

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

45mg
Copy link
Contributor

@45mg 45mg commented Mar 16, 2024

Evil users expect to be able to yank to named registers, but pdf-view only gives us `pdf-view-kill-ring-save'. So we implement our own version of evil-yank for pdf-view buffers.

@condy0919
Copy link
Collaborator

Fix the compile errors please.

modes/pdf/evil-collection-pdf.el:96:7: Error: mapconcat called with 2 arguments, but requires 3

and

modes/pdf/evil-collection-pdf.el:93:6: Error: the function ‘pdf-view-deactivate-region’ is not known to be defined.

@45mg
Copy link
Contributor Author

45mg commented Mar 19, 2024

Ok, the CI seems to be happy now.

@condy0919
Copy link
Collaborator

Squash your commits please.

Evil users expect to be able to yank to named registers, but pdf-view
only gives us `pdf-view-kill-ring-save'. So we implement our own version
of evil-yank for pdf-view buffers.
@45mg
Copy link
Contributor Author

45mg commented Mar 19, 2024

Done.

@condy0919 condy0919 merged commit 556ca31 into emacs-evil:master Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants