remove (defvar mu4e-mu-version)
#832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not overriding. |
|
Is it not already declared at https://github.com/djcb/mu/blob/aee76e47a86cb31edcf4ba70c0af9547db220e8c/mu4e/mu4e-config.el.in#L3 ? evil-collection-mu4e.el does not get the version of mu without this change for me. |
|
It looks like this was introduced in d3b497d to fix the bytecode compilation |
|
Ah, it looks like that I actually needed was 149eacc. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change evil-collection fails to pick up the mu4e-mu-version set in the mu4e module.
I'm new to emacs lisp but I think we're overriding the
mu4e-mu-versionvariable set in the mu4e module with one set in this module tonil.Any feedback or advice is welcome if this is the wrong solution.