Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evil-ex: elisp: eldoc #1410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nbfalcon
Copy link
Contributor

Extend evil-ex with eldoc similar to eval-expression for LISP expressions.


Refactor the `evil-ex' Elisp check into a new function, `evil-ex--elisp-p',
since it is used twice now. Add an `eldoc' function that calls
`elisp-eldoc-documentation-function' if in an Elisp expression and if the former
is available.
`make-variable-buffer-local' should not be used in Elisp and makes the argument
permanently buffer-local. Use `make-local-variable' + `set' instead, maing
`evil-ex-setup' not set `completion-at-point-functions' as permanently
buffer-local and allowing to remove `with-no-warnings'.
For Emacs < 24.4, which does not have `add-function' and `remove-function', use
`add-to-list' + `eldoc-documentation-functions' instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant