correctly clean up post command hooks

emacs-lsp · Sep 17, 2024 · f2e801f · f2e801f
1 parent 5617883
commit f2e801f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lsp-mode.el b/lsp-mode.el
@@ -4120,7 +4120,8 @@ yet."
     (cond
      ((and (or (equal lsp-signature-auto-activate t)
                (memq :on-trigger-char lsp-signature-auto-activate))
-           signature-help-handler)
+           signature-help-handler
+           (not cleanup?))
       (add-hook 'post-self-insert-hook signature-help-handler nil t))
 
      ((or cleanup?