Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beancount] Use the Rust version of language server #4134

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

gagbo
Copy link
Contributor

@gagbo gagbo commented Aug 13, 2023

The Python and Typescript versions of beancount-language-server are deprecated, the maintained version now is the Rust one.

TODO:

  • Create a tutorial to help people set the path to journal file using a modeline (maybe with eval so that the absolute path to journal file is dynamically computed ??) No need for tutorial, the journal file option will default to "current buffer", so it should cover most use cases.
  • Do we want to maintain legacy arguments for the older versions?

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Aug 13, 2023
@gagbo gagbo force-pushed the beancount/riir branch 3 times, most recently from 8916291 to 66124a4 Compare August 13, 2023 09:19
@gagbo
Copy link
Contributor Author

gagbo commented Aug 13, 2023

It's not ready to be merged yet, I haven't had time to test it properly

@gagbo gagbo marked this pull request as ready for review August 13, 2023 09:20
@gagbo
Copy link
Contributor Author

gagbo commented Aug 17, 2023

@jcs090218 Do you have any input on this? Pinging you as it seems you're the person who wrote the first version of the client, and I'm not sure whether there are specific maintainers to review the changes for less-used clients like this one.

@jcs090218
Copy link
Member

There is no specific maintainer for this client. The changes look reasonable.

Have you tested it already? If this work, then this shall be merged!

@gagbo
Copy link
Contributor Author

gagbo commented Aug 17, 2023

I only tested those with nvim now that I think about it, I'll test the changes in approx. 8-10 hours and report back!

@gagbo gagbo marked this pull request as draft August 17, 2023 17:06
@gagbo
Copy link
Contributor Author

gagbo commented Aug 17, 2023

Completion's not working for some reason, I'll try to clean that up

The Python and Typescript versions of beancount-language-server are
deprecated, the maintained version now is the Rust one.
@gagbo
Copy link
Contributor Author

gagbo commented Aug 17, 2023

It works now, I think I should not have tried to be fancy with the journalFile default value. nil will correctly initialize to the current buffer on the server side.

image

@gagbo gagbo marked this pull request as ready for review August 17, 2023 17:27
@jcs090218
Copy link
Member

LGTM! 👍

@yyoncho Can you give me higher merge permission? I get this Enable auto-merge every time I want to merge a PR. :(

2023-08-17 17 18 40

@yyoncho yyoncho merged commit 0dfe214 into emacs-lsp:master Aug 18, 2023
13 of 14 checks passed
@yyoncho
Copy link
Member

yyoncho commented Aug 18, 2023

@jcs090218 you are now added as admin but in general we should make this CI green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants