-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beancount] Use the Rust version of language server #4134
Conversation
8916291
to
66124a4
Compare
It's not ready to be merged yet, I haven't had time to test it properly |
@jcs090218 Do you have any input on this? Pinging you as it seems you're the person who wrote the first version of the client, and I'm not sure whether there are specific maintainers to review the changes for less-used clients like this one. |
There is no specific maintainer for this client. The changes look reasonable. Have you tested it already? If this work, then this shall be merged! |
I only tested those with nvim now that I think about it, I'll test the changes in approx. 8-10 hours and report back! |
Completion's not working for some reason, I'll try to clean that up |
The Python and Typescript versions of beancount-language-server are deprecated, the maintained version now is the Rust one.
LGTM! 👍 @yyoncho Can you give me higher merge permission? I get this |
@jcs090218 you are now added as admin but in general we should make this CI green. |
The Python and Typescript versions of beancount-language-server are deprecated, the maintained version now is the Rust one.
TODO:
Create a tutorial to help people set the path to journal file using a modeline (maybe withNo need for tutorial, the journal file option will default to "current buffer", so it should cover most use cases.eval
so that the absolute path to journal file is dynamically computed ??)