lsp-rust: Allow debugging with GDB 14. #4444
Conversation
| @@ -1541,7 +1541,7 @@ and run a compilation" | |||
| (`() (user-error "No compilation artifacts or obtaining the runnable artifacts failed")) | |||
| (`(,spec) spec) | |||
| (_ (user-error "Multiple compilation artifacts are not supported"))))) | |||
| (list :type "cppdbg" | |||
| (list :type (if (featurep 'dap-gdb) "gdb" "cppdbg") | |||
There was a problem hiding this comment.
Is gdb preferred over cppdb? 🤔
There was a problem hiding this comment.
As far as I understand it:
If the user doesn't do (require 'dap-gdb) in their emacs config file then dap-gdb.el won't be used anyway (even though the file is on disk), right?
So this way should be backward compatible with whatever users have configured now.
On the other hand, if someone adds (require 'dap-gdb) to their emacs config now then lsp-rust will switch over to gdb.
I didn't think of more use cases than that yet.
The only reason I do the (featurep 'dap-gdb) is because I just touched it so I'm very sure it works.
Long term, this entire spot could use some automatic "which debugger features are there, which will actually work, and of those, which one should we prefer for the default debugger profile" policy--but I don't know whether we want that and when and whether it already exists.
Since GDB 14 now supports DAP natively, we can also just use GDB instead of vscode-cpptools. Try that in lsp-rust.
See also emacs-lsp/dap-mode#790, which is required.