Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add earthlyls lsp client #4471

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: Add earthlyls lsp client #4471

merged 1 commit into from
Jun 13, 2024

Conversation

Konubinix
Copy link
Contributor

  • feat: Add earthlyls lsp client (using lsp-asm.el as reference)

  • feat: Provide a way to download the server automatically

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Jun 4, 2024
@Konubinix
Copy link
Contributor Author

I think that the failing checks are not linked to the changes related to this PR. I looked at some other PR and saw them fail for the same reason they are failing here.

Am I right?

@jcs090218
Copy link
Member

Please ignore the snapshot test results. Can you update the changelog, too? Thanks!

* feat: Add earthlyls lsp client (using lsp-asm.el as reference)

* feat: Provide a way to download the server automatically
@Konubinix
Copy link
Contributor Author

Please ignore the snapshot test results. Can you update the changelog, too? Thanks!

Done. I also rebased the code on top of the master branch.

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jcs090218 jcs090218 merged commit 90ca22e into emacs-lsp:master Jun 13, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants