Switch tool detection for lsp-unzip (#3022) #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will force powershell on linux which IIRC was causing trouble in the past. Can you add additional condition (if on windows and if powershell there - use it) |
|
Just pushed a new version, is this what you had in mind ? Btw, thanks a lot for your selfless work on lsp-mode. |
can you keep that too in the end? |
Horrih
force-pushed
the
fix-lsp-unzip-windows
branch
from
706afe1
to
cfdd642
Compare
It caused issues on windows if unzip was found on the PATH
Horrih
force-pushed
the
fix-lsp-unzip-windows
branch
from
cfdd642
to
fe48989
Compare
|
Sure, is that better ? I rebased onto master + squashed the previous commits |
jcs090218
approved these changes
Sep 30, 2024
|
LGTM! Thank you for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caused issues on windows if unzip was found on the PATH, because it fell back to the bash command + unzip.
Changing in order of detection fixes the issue.