Fix processing of multibyte messages #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Too many characters are read from back-to-back multibyte messages due to a conversion from byte-length to character length * Updated to immediately convert messages to unibyte when processing
|
Fixes #4250 |
kiennq
reviewed
Sep 1, 2024
lsp-mode.el
Outdated
| @@ -7041,8 +7041,8 @@ server. WORKSPACE is the active workspace." | |||
| leftovers body-length body chunk) | |||
| (lambda (_proc input) | |||
| (setf chunk (if (s-blank? leftovers) | |||
| input | |||
| (concat leftovers input))) | |||
| (encode-coding-string input 'utf-8-unix) | |||
There was a problem hiding this comment.
nit: using the 3rd parameters of nocopy might be better due to we don't have to duplicate the string.
Can you check if it still working okay with that?
kiennq
approved these changes
Sep 23, 2024
|
Any follow-ups? |
|
Hi, sorry, lost track of this. Can confirm that using the third param of |
|
@JeremyWeed same; I had forked your repository and rebased it with this one and seems like I have no issues anymore |
nvimtor
pushed a commit
to nvimtor/lsp-mode
that referenced
this pull request
Nov 11, 2024
* Fix processing of multibyte messages * Too many characters are read from back-to-back multibyte messages due to a conversion from byte-length to character length * Updated to immediately convert messages to unibyte when processing * Update encoding logic to avoid copies --------- Co-authored-by: weedjer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many characters are read from back-to-back multibyte messages due to a conversion from byte-length to character length
Updated to immediately convert messages to unibyte when processing