Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix lsp-sqls-workspace-config-path behavior #4535

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

suzuki
Copy link
Contributor

@suzuki suzuki commented Aug 31, 2024

About

The current lsp-sql documentation does not match the actual behavior.

Alternatively, you can leave lsp-sqls-workspace-config-path to the default "workspace" value, and put a json file in /.sqls/config.json containing

This is incorrect. The current behavior is to define "root" instead of "workspace."

Codes

(if lsp-sqls-connections
(lsp--set-configuration `(:sqls (:connections ,(apply #'vector lsp-sqls-connections))))
(when-let ((config-json-path (cond
((equal lsp-sqls-workspace-config-path "workspace")
".sqls/config.json")
((equal lsp-sqls-workspace-config-path "root")
(-> (lsp-workspace-root)
(f-join ".sqls/config.json"))))))

Notes

I am not a native English speaker. Please let me know if there are any unnatural phrases in this pull request.

@jcs090218 jcs090218 merged commit 213f207 into emacs-lsp:master Sep 14, 2024
10 of 13 checks passed
@jcs090218
Copy link
Member

Thank you!

@suzuki suzuki deleted the lsp-sqls-update-doc branch September 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants