Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mode inputs on lsp-eslint-working-directory #4554

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iyefrat
Copy link

@iyefrat iyefrat commented Sep 21, 2024

eslint.workingDirectories accepts {"mode": "auto"} and {"mode": "location"} inputs (see 0). auto is particulalry important for using eslint in a monorepo setting.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Sep 21, 2024
`eslint.workingDirectories` accepts `{"mode": "auto"}` and `{"mode":
"location"}` inputs (see [0]). `auto` is particulalry important for
using eslint in a monorepo setting.

[0]: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
@iyefrat iyefrat force-pushed the feature/support-mode-auto-working-directory branch from 74ae59b to 3499500 Compare September 21, 2024 23:28
@iyefrat iyefrat marked this pull request as draft September 21, 2024 23:33
@iyefrat iyefrat marked this pull request as ready for review September 26, 2024 13:54
@jcs090218
Copy link
Member

jcs090218 commented Sep 30, 2024

There is one compile warning:

lsp-eslint.el:135:2: Warning: custom-declare-variable `lsp-eslint-working-directories' docstring wider than 80 characters

Otherwise, LGTM! :)

@iyefrat
Copy link
Author

iyefrat commented Oct 12, 2024

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants