Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for futhark mode #4556

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Conversation

SKyletoft
Copy link
Contributor

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Sep 22, 2024
clients/lsp-futhark.el Outdated Show resolved Hide resolved
@jcs090218
Copy link
Member

You can use this PR as a reference, see https://github.com/emacs-lsp/lsp-mode/pull/4447/files.

@SKyletoft
Copy link
Contributor Author

I think that's it?

There is no configuration to support and the server is a part of the compiler so that seems out of scope.

@jcs090218
Copy link
Member

Can you add the defgroup and link it to the server URL?

I recommend adding that information. It's better to have some documentation rather than no documentation at all.

@SKyletoft
Copy link
Contributor Author

Can you add the defgroup and link it to the server URL?

I recommend adding that information. It's better to have some documentation rather than no documentation at all.

Do I link the specific folder or just the repo? It's a part of the compiler and the lsp has no readme, just a blog annoucement

@SKyletoft
Copy link
Contributor Author

Added with a link to the lsp. And sorry for being a bother.

@jcs090218
Copy link
Member

Added with a link to the lsp. And sorry for being a bother.

No worries. Thant make sense! :)

Can you change the lsp-clients.json and add the installation instruction. 🤔 See other settings for references.

docs/lsp-clients.json Outdated Show resolved Hide resolved
@jcs090218
Copy link
Member

Thank you for your hard work on this! 😋

@jcs090218 jcs090218 merged commit 9222365 into emacs-lsp:master Sep 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants